Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distsqlrun: start indexjoiner's row fetcher input #27942

Merged
merged 1 commit into from
Jul 26, 2018

Conversation

jordanlewis
Copy link
Member

Fixes #27914.

Previously, indexjoiner failed to start its input RowFetcherWrapper.
This caused a potential panic with logging and kv tracing, and is
corrected by this patch.

Release note (bug fix): fix a panic caused by kv tracing a plan that
uses an index joiner

Previously, indexjoiner failed to start its input RowFetcherWrapper.
This caused a potential panic with logging and kv tracing, and is
corrected by this patch.

Release note (bug fix): fix a panic caused by kv tracing a plan that
uses an index joiner
@jordanlewis jordanlewis requested review from knz, solongordon and a team July 26, 2018 05:03
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick turnaround!

@jordanlewis
Copy link
Member Author

bors r+

craig bot pushed a commit that referenced this pull request Jul 26, 2018
27942: distsqlrun: start indexjoiner's row fetcher input r=jordanlewis a=jordanlewis

Fixes #27914.

Previously, indexjoiner failed to start its input RowFetcherWrapper.
This caused a potential panic with logging and kv tracing, and is
corrected by this patch.

Release note (bug fix): fix a panic caused by kv tracing a plan that
uses an index joiner

Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
@craig
Copy link
Contributor

craig bot commented Jul 26, 2018

Build succeeded

@craig craig bot merged commit bc1c840 into cockroachdb:master Jul 26, 2018
@jordanlewis jordanlewis deleted the start-index-joiner branch July 26, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: kv tracing makes distsql explode
3 participants