distsql: add remaining seq fns to blacklist #28114
Conversation
There were still a couple of sequence functions that weren't properly blacklisted from running in DistSQL. Release note (bug fix): prevent some sequence builtins from incorrectly running in distributed flows.
jordanlewis
requested review from
andreimatei,
solongordon,
rjnn,
asubiotto and
a team
|
This change is |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
There was a problem hiding this comment.
Reviewable status:
pkg/sql/sem/builtins/builtins.go, line 1462 at r1 (raw file):
tree.FunctionProperties{ Category: categorySequences, DistsqlBlacklist: true,
I forgot what we discussed... Wasn't currval supposed to work?
There was a problem hiding this comment.
Reviewable status:
pkg/sql/sem/builtins/builtins.go, line 1462 at r1 (raw file):
Previously, andreimatei (Andrei Matei) wrote…
I forgot what we discussed... Wasn't currval supposed to work?
Maybe it should, but the current implementation doesn't let it. I could fix that now too, I suppose
There was a problem hiding this comment.
Reviewable status:
pkg/sql/sem/builtins/builtins.go, line 1462 at r1 (raw file):
Previously, jordanlewis (Jordan Lewis) wrote…
Maybe it should, but the current implementation doesn't let it. I could fix that now too, I suppose
I'll fix it in a separate PR.
|
bors r+ |
|
👎 Rejected by code reviews |
jordanlewis
dismissed
andreimatei’s stale review
because i'll fix it in another pr
|
bors r+ |
28114: distsql: add remaining seq fns to blacklist r=jordanlewis a=jordanlewis There were still a couple of sequence functions that weren't properly blacklisted from running in DistSQL. Release note (bug fix): prevent some sequence builtins from incorrectly running in distributed flows. Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
There was a problem hiding this comment.
Reviewable status:
pkg/sql/sem/builtins/builtins.go, line 1462 at r1 (raw file):
Previously, jordanlewis (Jordan Lewis) wrote…
I'll fix it in a separate PR.
Wait, no, it's not really possible without major surgery. The problem is that resolving a sequence name (which currval accepts) requires a ton of infrastructure which isn't available on remote flows yet.
Build succeeded |
There were still a couple of sequence functions that weren't properly
blacklisted from running in DistSQL.
Release note (bug fix): prevent some sequence builtins from incorrectly
running in distributed flows.