cli: control the sum of --cache + --max-sql-memory #28199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note (cli change): `cockroach start` now reports a waraning if more than 75% of available RAM is reserved by `--cache` and `--max-sql-memory`.
|
This change is |
petermattis
approved these changes
Aug 2, 2018
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
|
thanks bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 2, 2018
28199: cli: control the sum of --cache + --max-sql-memory r=knz a=knz Fixes #24396 Release note (cli change): `cockroach start` now reports a waraning if more than 75% of available RAM is reserved by `--cache` and `--max-sql-memory`. Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24396
Release note (cli change):
cockroach startnow reports a waraning ifmore than 75% of available RAM is reserved by
--cacheand--max-sql-memory.