changefeedccl: substitute placeholders in job description #28220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note (enterprise change): CHANGEFEED job descriptions now substitute values for sql placeholders
|
This change is |
nvanbenschoten
approved these changes
Aug 3, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
|
bors r=nvanbenschoten |
craig bot
pushed a commit
that referenced
this pull request
Aug 3, 2018
27996: jobspb,changefeedccl: finalize ChangefeedDetails job proto for 2.1 r=nvanbenschoten a=danhhz For now, this commit removes remove any table expansions, including databases. Getting it right as tables enter and leave the set over time is tricky (as we learned fixing it in incremental backup). This simplification allows us to store the targeted tables as a list of IDs. Table IDs can change over time, such as with TRUNCATE, and the changefeed is responsible for detecting this or preventing it. Post 2.1, we'll reconsider supporting name expansions and how that should be represented in this proto. Release note (enterprise change): CHANGEFEEDs can now only target lists of physical tables 28220: changefeedccl: substitute placeholders in job description r=nvanbenschoten a=danhhz Release note (enterprise change): CHANGEFEED job descriptions now substitute values for sql placeholders Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (enterprise change): CHANGEFEED job descriptions now
substitute values for sql placeholders