ui: right align stats on node list #28545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
BramGruneir
approved these changes
Aug 14, 2018
There was a problem hiding this comment.
LGTM, but I didn't know we were adding in specialty styles at this granularity. Why not add right-alighted-stat to the same style file where sort-table__cell is defined?
Also, might want to right align uptime as well.
Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained
added 2 commits
August 14, 2018 00:49
These don't actually fail the linter, but are inconsistent with style elsewhere. Should make the linter more strict. Release note: None
Not as good as a bar graph, but still makes it easier to compare quantities. Release note: None
vilterp
force-pushed
the
right-align-stats
branch
from
823ec45
to
a45f250
Compare
|
Good point. Knew there was a better place for this. Moved it. bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 14, 2018
28545: ui: right align stats on node list r=vilterp a=vilterp Not as good as a bar graph, but still makes it easier to compare quantities. Before:  After:  Co-authored-by: Pete Vilter <vilterp@cockroachlabs.com>
Build succeeded |
|
sure, the full text is right-aligned, but only the percentage is truly right-aligned. kind of frustrating that the values jump around based on the width of the percentages... |
This was referenced Aug 29, 2018
|
Yeah, this was a quick fix which makes it better but not great. Filed #29373 to revisit this with a better design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not as good as a bar graph, but still makes it easier to compare quantities.
Before:
After:
