Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: node list: enhance HW metrics totals & percentages #29373

Closed
vilterp opened this issue Aug 30, 2018 · 1 comment
Closed

ui: node list: enhance HW metrics totals & percentages #29373

vilterp opened this issue Aug 30, 2018 · 1 comment
Assignees
@couchand
Labels
A-webui-layout-and-style C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
Web UI

Comments

@vilterp
Copy link
Contributor

vilterp commented Aug 30, 2018 •
edited

Followup to work in #28545 and #28189:

The node list shows disk and memory usage:

image
(Hover over a cell to get a total)

It tries to indicate the total amount, the amount used, and what percentage that is. A couple of problems:

  • Tooltip takes a couple seconds to show up. Not very convenient or discoverable.
  • Would be nice to see bars instead of percentage numbers.
  • The text in the cells is right-aligned, but only the percentages are really right-aligned, not the values.

@josueeee has some designs for this, e.g.:
image

Should revisit those and implement one of them.

cc @piyush-singh
@vilterp vilterp created this issue from a note in Web UI (Sprint: Todo) Aug 30, 2018
@vilterp vilterp added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-monitoring A-webui-layout-and-style labels Aug 30, 2018
@vilterp vilterp mentioned this issue Aug 30, 2018
Merged
@josueeee
Copy link

josueeee commented Sep 4, 2018

@vilterp As I recall from feedback, the team wanted to move forward the "Direction E" from the Explorations_v2 page of the Figma file: https://www.figma.com/file/WzhvMEGkuDi8Wd7va0vgHHiG/Hardware-Metrics?node-id=129%3A2

Just made a slight change in color to the % so it doesn't appear as a link.

@couchand couchand self-assigned this Sep 4, 2018
@couchand couchand added this to the 2.1 milestone Sep 4, 2018
@vilterp vilterp mentioned this issue Sep 21, 2018
Merged
@piyush-singh piyush-singh mentioned this issue Oct 2, 2018
Closed
@vilterp vilterp moved this from Sprint: Todo to Sprint: In Progress in Web UI Oct 4, 2018
@couchand couchand mentioned this issue Oct 4, 2018
Merged
@petermattis petermattis removed this from the 2.1 milestone Oct 5, 2018
couchand added a commit to couchand/cockroach that referenced this issue Oct 5, 2018
@couchand
ui: add bar chart for node list memory & capacity
e03a2b5 
Fixes: cockroachdb#29373
Release note (admin ui change): Adds a bar chart to the memory and
capacity usage columns on the node list.
craig bot pushed a commit that referenced this issue Oct 5, 2018
@knz @couchand
Merge #29623 #30982
ff29ad4 
29623: sql: improve the table name prefix resolution error message r=knz a=knz

Fixes #29594.

Before:

```
root@127.0.0.1:44824/defaultdb> create table t.t(x int);
pq: no schema has been selected to create "t.t" in
HINT: verify that the current database and search_path are valid
```

After:

```
root@127.0.0.1:36392/defaultdb> create table t.t(x int);
pq: cannot create "t.t" because the target database or schema does not exist
HINT: verify that the current database and search_path are valid and/or the target database exists
```

Release note: None

30982: ui: add bar chart for node list memory & capacity r=couchand a=couchand

Adds bar charts to capacity and memory columns on the node list.

![new-node-list](https://user-images.githubusercontent.com/793969/46502317-dccae700-c7f5-11e8-9c02-b3795137f10d.png)

Closes #29373

Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Co-authored-by: Andrew Couch <hi@andrewcou.ch>
@craig craig bot closed this as completed in #30982 Oct 5, 2018
Web UI automation moved this from Sprint: In Progress to Sprint: Done Oct 5, 2018
couchand added a commit to couchand/cockroach that referenced this issue Oct 8, 2018
@couchand
ui: add bar chart for node list memory & capacity
d2a7be9 
Fixes: cockroachdb#29373
Release note (admin ui change): Adds a bar chart to the memory and
capacity usage columns on the node list.
@couchand couchand mentioned this issue Oct 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@couchand couchand

Labels
A-webui-layout-and-style C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
No open projects
Web UI
  
Sprint: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vilterp @couchand @petermattis @josueeee