storage/engine: invalidate cached iterator state when necessary #28794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
benesch
approved these changes
Aug 18, 2018
There was a problem hiding this comment.
Assume you're planning to backport this?
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
pkg/storage/engine/mvcc_test.go, line 1323 at r1 (raw file):
} // Perform a Get or Scan.
nit: "or FindSplitKey or Compute Stats". Maybe rephrase to "perform the operation"? Or maybe just drop the comment entirely.
`Iterator.{MVCCGet,MVCCScan,FindSplitKey,ComputeStats}` need to
invalidate the cached iterator state. They were previously failing to do
so which could lead to rare scenarios where a key could be considered
present in the database which had never been written.
Fixes cockroachdb#28025
Release note (bug fix): Fix rare scenario where the value written for
one system key was seen when another system key was read leading to the
violation of internal invariants.
petermattis
force-pushed
the
pmattis/ycsb-bug
branch
from
f69e21e
to
b1aaee4
Compare
petermattis
commented
Aug 18, 2018
There was a problem hiding this comment.
Yes, I'm planning on backporting this.
Reviewable status:
pkg/storage/engine/mvcc_test.go, line 1323 at r1 (raw file):
Previously, benesch (Nikhil Benesch) wrote…
nit: "or FindSplitKey or Compute Stats". Maybe rephrase to "perform the operation"? Or maybe just drop the comment entirely.
Removed. I was diligently commenting while developing and then extended the test.
benesch
approved these changes
Aug 18, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
|
bors r=benesch |
craig bot
pushed a commit
that referenced
this pull request
Aug 18, 2018
28794: storage/engine: invalidate cached iterator state when necessary r=benesch a=petermattis
`Iterator.{MVCCGet,MVCCScan,FindSplitKey,ComputeStats}` need to
invalidate the cached iterator state. They were previously failing to do
so which could lead to rare scenarios where a key could be considered
present in the database which had never been written.
Fixes #28025
Release note (bug fix): Fix rare scenario where the value written for
one system key was seen when another system key was read leading to the
violation of internal invariants.
Co-authored-by: Peter Mattis <petermattis@gmail.com>
|
Can't review now and don't wait for me, just wanted to mention that you're
linking the wrong issue.
On Sat, Aug 18, 2018, 9:43 PM Peter Mattis ***@***.***> wrote:
bors r=benesch
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#28794 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE135K8Cw_YWYgAO75hS8QASIK3TbkJLks5uSG5LgaJpZM4WCqgq>
.
--
…-- Tobias
|
Build succeeded |
Gah! Too late! |
craig bot
pushed a commit
that referenced
this pull request
Aug 18, 2018
28798: release-2.0: storage/engine: invalidate cached iterator state when necessary r=benesch a=petermattis Backport 1/1 commits from #28794. /cc @cockroachdb/release --- `Iterator.{MVCCGet,MVCCScan,FindSplitKey,ComputeStats}` need to invalidate the cached iterator state. They were previously failing to do so which could lead to rare scenarios where a key could be considered present in the database which had never been written. Fixes #28025 Release note (bug fix): Fix rare scenario where the value written for one system key was seen when another system key was read leading to the violation of internal invariants. Co-authored-by: Peter Mattis <petermattis@gmail.com>
|
Well color me confused. Could have sworn I clicked on that issue link when
I reviewed this.
…On Sat, Aug 18, 2018 at 4:10 PM Peter Mattis ***@***.***> wrote:
Can't review now and don't wait for me, just wanted to mention that you're
linking the wrong issue.
Gah! Too late!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#28794 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA15IAtYo4F4SNQT_y2UUgD_UQLDDFBOks5uSHTMgaJpZM4WCqgq>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterator.{MVCCGet,MVCCScan,FindSplitKey,ComputeStats}need toinvalidate the cached iterator state. They were previously failing to do
so which could lead to rare scenarios where a key could be considered
present in the database which had never been written.
Fixes #28025
Release note (bug fix): Fix rare scenario where the value written for
one system key was seen when another system key was read leading to the
violation of internal invariants.