release-2.0: storage/engine: invalidate cached iterator state when necessary #28798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
petermattis
force-pushed
the
backport2.0-28794
branch
from
91dc519
to
b579df6
Compare
benesch
approved these changes
Aug 18, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
pkg/storage/engine/mvcc_test.go, line 1329 at r1 (raw file):
_, _, _, err = MVCCScan(ctx, batch, key, roachpb.KeyMax, math.MaxInt64, ts2, true, nil) case "findSplitKey": _, err = MVCCFindSplitKey(ctx, batch, roachpb.RKeyMin, roachpb.RKeyMax, 64<<20)
Looks like this function takes an additional final allowMeta2Splits param on 2.0.
`Iterator.{MVCCGet,MVCCScan,FindSplitKey,ComputeStats}` need to
invalidate the cached iterator state. They were previously failing to do
so which could lead to rare scenarios where a key could be considered
present in the database which had never been written.
Fixes cockroachdb#28025
Release note (bug fix): Fix rare scenario where the value written for
one system key was seen when another system key was read leading to the
violation of internal invariants.
petermattis
force-pushed
the
backport2.0-28794
branch
from
b579df6
to
fc0bdd1
Compare
|
bors r=benesch |
craig bot
pushed a commit
that referenced
this pull request
Aug 18, 2018
28798: release-2.0: storage/engine: invalidate cached iterator state when necessary r=benesch a=petermattis Backport 1/1 commits from #28794. /cc @cockroachdb/release --- `Iterator.{MVCCGet,MVCCScan,FindSplitKey,ComputeStats}` need to invalidate the cached iterator state. They were previously failing to do so which could lead to rare scenarios where a key could be considered present in the database which had never been written. Fixes #28025 Release note (bug fix): Fix rare scenario where the value written for one system key was seen when another system key was read leading to the violation of internal invariants. Co-authored-by: Peter Mattis <petermattis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #28794.
/cc @cockroachdb/release
Iterator.{MVCCGet,MVCCScan,FindSplitKey,ComputeStats}need toinvalidate the cached iterator state. They were previously failing to do
so which could lead to rare scenarios where a key could be considered
present in the database which had never been written.
Fixes #28025
Release note (bug fix): Fix rare scenario where the value written for
one system key was seen when another system key was read leading to the
violation of internal invariants.