sql: null array element in cast is null #28860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
approved these changes
Aug 20, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
|
TFTR! bors r+ |
|
bors r- need to update some tests |
Canceled |
Prior, `ARRAY[NULL]::STRING[]` would be `ARRAY['NULL']`, rather than `ARRAY[NULL]`. This was because the evaluation of a CastExpr prior would handle nulls by itself and so the extra case in the switch statement went unnoticed. Release note (bug fix): Casting arrays now correctly preserves NULL values.
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 20, 2018
28860: sql: null array element in cast is null r=justinj a=justinj Prior, `ARRAY[NULL]::STRING[]` would be `ARRAY['NULL']`, rather than `ARRAY[NULL]`. This was because the evaluation of a CastExpr prior would handle nulls by itself and so the extra case in the switch statement went unnoticed. Release note (bug fix): Casting arrays now correctly preserves NULL values. Co-authored-by: Justin Jaffray <justin@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior,
ARRAY[NULL]::STRING[]would beARRAY['NULL'], rather thanARRAY[NULL]. This was because the evaluation of a CastExpr prior wouldhandle nulls by itself and so the extra case in the switch statement
went unnoticed.
Release note (bug fix): Casting arrays now correctly preserves NULL
values.