release-2.1: sql: fix evaluation of <tuple> IS NULL #30184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, the comparison op overload for the IsNotDistinctFrom operation with tuple inputs had NullableArgs incorrectly set to false. As a result, the output was incorrect for queries such as: SELECT (1, 2, 3) IS NULL This query should return false, but instead it returned NULL. This commit fixes this bug. Release note (bug fix): Fixed the evaluation of <tuple> IS NOT NULL and <tuple> IS NULL comparison operations involving a non-null constant tuple to return true or false rather than NULL.
|
This change is |
|
Backporting all of #30022 together was causing issues (this commit needs to be ordered first, but was created after the other two), so I'm backporting this commit first, then will do the other two. |
andy-kimball
approved these changes
Sep 13, 2018
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/3 commits from #30022.
/cc @cockroachdb/release
Prior to this patch, the comparison op overload for the
IsNotDistinctFrom operation with tuple inputs had NullableArgs
incorrectly set to false. As a result, the output was incorrect
for queries such as:
SELECT (1, 2, 3) IS NULL
This query should return false, but instead it returned NULL.
This commit fixes this bug.
Release note (bug fix): Fixed the evaluation of IS NOT NULL and
IS NULL comparison operations involving a non-null constant tuple
to return true or false rather than NULL.