release-2.1: changefeedccl: deflake TestChangefeedRetryableSinkError #30200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestChangefeedRetryableSinkError was performing many rounds of bcrypt, which is excruciatingly slow when the race detector is on. Put its test cluster into insecure mode to skip bcrypt hashing. Fix cockroachdb#30156. Fix cockroachdb#30161. Release note: None
The previous pattern used to drain a channel
if len(ch) > 0 {
<-ch
}
is considered a race by the race detector if close(ch) occurs at the
same time. Adjust the channel-draining code to be race-safe by instead
perfomring repeated nonblocking reads.
Fix cockroachdb#30159.
Release note: None
|
This change is |
danhhz
approved these changes
Sep 13, 2018
nvanbenschoten
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #30172.
/cc @cockroachdb/release
TestChangefeedRetryableSinkError was performing many rounds of bcrypt,
which is excruciatingly slow when the race detector is on. Put its test
cluster into insecure mode to skip bcrypt hashing.
Fix #30156.
Fix #30161.
Release note: None