Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-2.1: changefeedccl: deflake TestChangefeedRetryableSinkError #30200

Merged
merged 2 commits into from
Sep 13, 2018
Merged

release-2.1: changefeedccl: deflake TestChangefeedRetryableSinkError #30200

merged 2 commits into from
Sep 13, 2018

Commits on Sep 13, 2018

  1. changefeedccl: deflake TestChangefeedRetryableSinkError 

    TestChangefeedRetryableSinkError was performing many rounds of bcrypt,
which is excruciatingly slow when the race detector is on. Put its test
cluster into insecure mode to skip bcrypt hashing.

Fix cockroachdb#30156.
Fix cockroachdb#30161.

Release note: None
    @benesch
    benesch committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    3d64d9f View commit details
    Browse the repository at this point in the history

  2. storage: fix race when draining rangefeed channel 

    The previous pattern used to drain a channel

    if len(ch) > 0 {
        <-ch
    }

is considered a race by the race detector if close(ch) occurs at the
same time. Adjust the channel-draining code to be race-safe by instead
perfomring repeated nonblocking reads.

Fix cockroachdb#30159.

Release note: None
    @benesch
    benesch committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    4ee48ef View commit details
    Browse the repository at this point in the history