ui: add bar chart for node list memory & capacity #30982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
couchand
force-pushed
the
feature/node-list-updates
branch
from
68f5601
to
465ef50
Compare
|
Seeing this in Chrome
and this in Firefox
Oy. |
vilterp
reviewed
Oct 4, 2018
| } | ||
|
|
||
| render() { | ||
| console.log("foobar!"); |
Release note: None
couchand
force-pushed
the
feature/node-list-updates
branch
2 times, most recently
from
23d5ee5
to
0cf98d9
Compare
Fixes: cockroachdb#29373 Release note (admin ui change): Adds a bar chart to the memory and capacity usage columns on the node list.
Release note (admin ui change): Sorting by the memory or capacity usage column on the node list now sorts by percentage used.
Chrome and Firefox have different rules about CSS selectivity for SVG elements, apparently. This is a hack, we should find a simpler way to handle this (maybe changing the conflicting classes). Release note: None
couchand
force-pushed
the
feature/node-list-updates
branch
from
0cf98d9
to
f1b2a73
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 5, 2018
29623: sql: improve the table name prefix resolution error message r=knz a=knz Fixes #29594. Before: ``` root@127.0.0.1:44824/defaultdb> create table t.t(x int); pq: no schema has been selected to create "t.t" in HINT: verify that the current database and search_path are valid ``` After: ``` root@127.0.0.1:36392/defaultdb> create table t.t(x int); pq: cannot create "t.t" because the target database or schema does not exist HINT: verify that the current database and search_path are valid and/or the target database exists ``` Release note: None 30982: ui: add bar chart for node list memory & capacity r=couchand a=couchand Adds bar charts to capacity and memory columns on the node list.  Closes #29373 Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com> Co-authored-by: Andrew Couch <hi@andrewcou.ch>
|
This change is |
|
Annoyingly, there's still a difference, with spacing — numbers right up against the bar in Chrome; properly spaced in FF: FF: |
Build succeeded |
|
@vilterp I'm not seeing that in Chrome on Linux, I'll take a look Monday. |
|
Hm looking ok now in Chrome… Overall this is looking really nice! |
This was referenced Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bar charts to capacity and memory columns on the node list.
Closes #29373