release-2.1: changefeedccl: support a minimum frequency between resolved ts emits #31008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `WITH resolved` option now take an optional duration which is used as a lower bound on the duration between emitted resolved timestamps. It accepts any format that https://golang.org/pkg/time/#ParseDuration does. (e.g. `WITH resolved='10s'`). If unspecified, the previous behavior of emitting all resolved timestamps is used. `resolved` is now the first `WITH` option to optionally take a value, so this required a small refactor to make an enum from the bool specifing whether the value was required. Closes cockroachdb#30367 Release note (enterprise change): CHANGEFEEDs can now be configured with a minimum duration between emitted resolved timestamps.
|
This change is |
mrtracy
approved these changes
Oct 8, 2018
complete! 0 of 0 LGTMs obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #30974.
/cc @cockroachdb/release
The
WITH resolvedoption now take an optional duration which is usedas a lower bound on the duration between emitting resolved timestamps.
It accepts any format that https://golang.org/pkg/time/#ParseDuration
does. (e.g.
WITH resolved='10s'). If unspecified, the previousbehavior of emitting all resolved timestamps is used.
Closes #30367
Release note (enterprise change): CHANGEFEEDs can now be configured with
a minimum duration between emitting resolved timestamps.