release-2.1: sql: skip removed nodes in crdb_internal.gossip_nodes #32198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I penciled a release note into the original PR's description, might adding that here as well? |
mvijaykarthik
force-pushed
the
backport2.1-32151
branch
from
a0882c8
to
dcee561
Compare
Removed nodes have empty info proto. Skip them while processing rows in crdb_internal.gossip_nodes Fixes cockroachdb#31696 Release note (bug fix): Fix an error returned by node status after a new node is added to the cluster at a previous node's address.
mvijaykarthik
force-pushed
the
backport2.1-32151
branch
from
dcee561
to
d6c888d
Compare
|
A minor change I had to make in the cherry-pick was remove |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 9, 2018
32198: release-2.1: sql: skip removed nodes in crdb_internal.gossip_nodes r=tschottdorf a=mvijaykarthik Removed nodes have empty info proto. Skip them while processing rows in crdb_internal.gossip_nodes Fixes #31696 Release note (bug fix): Fix an error returned by node status after a new node is added to the cluster at a previous node's address. Co-authored-by: Vijay Karthik <vijay.karthik@rubrik.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed nodes have empty info proto. Skip them while processing
rows in crdb_internal.gossip_nodes
Fixes #31696
Release note (bug fix): Fix an error returned by node status after
a new node is added to the cluster at a previous node's address.