release-2.1: sql,server: fix the listing of sessions for admin/root users #32709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Admin users should be able to list all sessions not just their own. This was broken in cockroachdb#32253 and thus in 2.1.1 (was ok in 2.1.0 and prior). This patch fixes this and also clarifies the code responsible. Release note (bug fix): CockroachDB now again enables admin users, including `root`, to list all user sessions besides their own.
|
This change is |
|
@a-robinson I am not reliably online today. to ensure this gets merged on time, feel free to merge on green |
a-robinson
approved these changes
Nov 29, 2018
knz
moved this from Triage
to Finished (m2.2-2)
in (DEPRECATED) SQL Front-end, Lang & Semantics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #32629.
/cc @cockroachdb/release