[wip] sql: pgwire support for limited result sets #33174
Conversation
|
This change is |
jordanlewis
force-pushed
the
portal-limit
branch
from
694c324
to
d933ba4
Compare
jordanlewis
force-pushed
the
portal-limit
branch
from
d933ba4
to
21f146a
Compare
| stmtRes := ex.clientComm.CreateStatementResult( | ||
| tcmd.Stmt, NeedRowDesc, pos, nil, /* formatCodes */ | ||
| ex.sessionData.DataConversion) | ||
| stmtRes := ex.clientComm.CreateStatementResult(tcmd.Stmt, NeedRowDesc, pos, nil, ex.sessionData.DataConversion, 0) |
There was a problem hiding this comment.
The nil and 0 should be documented inline.
| r.seenTuples = 0 | ||
|
|
||
| return r.moreResultsNeeded() | ||
|
|
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained
pkg/sql/conn_executor_exec.go, line 934 at r1 (raw file):
} ex.sessionTracing.TraceExecRowsResult(consumeCtx, values) quitEarly, commErr = res.AddRow(consumeCtx, values)
AddRow returns what seems to be the inverse of "quit early".
This commit adds support for portal execution with limits, which is the part of the pgwire protocol that JDBC uses if you use its native pagination with `setFetchSize`. Release note (sql change): add support for row limits in prepared portals at the pgwire layer, enabling support for client-side pagination with things like JDBC's `setFetchSize`. Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com> Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
jordanlewis
force-pushed
the
portal-limit
branch
from
21f146a
to
f09b351
Compare
|
Jordan can you give me write permissions on your repo? I can't push my changes. We still need to figure out the testing story. |
|
@jordanlewis @andreimatei could you brush up this PR to have a first MVP in 19.1 before the branch is cut? We can fix up with backports as needed afterwards. |
|
Well this was not the right way to go, in my opinion - the "command result" taking over the For this one in particular, my heart is definitely not in it. |
This commit adds support for portal execution with limits, which is the
part of the pgwire protocol that JDBC uses if you use its native
pagination with
setFetchSize.Closes #4035.
Release note (sql change): add support for row limits in prepared
portals at the pgwire layer, enabling support for client-side pagination
with things like JDBC's
setFetchSize.Co-authored-by: Jordan Lewis jordanthelewis@gmail.com
Co-authored-by: Andrei Matei andrei@cockroachlabs.com