vendor: update thrift and zipkin-go-opentracing #33287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#30576. Informs cockroachdb#30774. openzipkin-contrib/zipkin-go-opentracing@4c9fbcb...f0f479a apache/thrift@327ebb6...2b7365c I audited every commit in the zipkin-go-opentracing diff and every commit to the `lib/go` package of the thrift diff. Release note (bug fix): Updated Zipkin library to avoid deadlock when stopping Zipkin tracing.
|
This change is |
RaduBerinde
approved these changes
Dec 19, 2018
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 19, 2018
33287: vendor: update thrift and zipkin-go-opentracing r=nvanbenschoten a=nvanbenschoten Fixes #30576. Informs #30774. openzipkin-contrib/zipkin-go-opentracing@4c9fbcb...f0f479a apache/thrift@327ebb6...2b7365c I audited every commit in the zipkin-go-opentracing diff and every commit to the `lib/go` package of the thrift diff. Release note (bug fix): Updated Zipkin library to avoid deadlock when stopping Zipkin tracing. Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30576.
Informs #30774.
openzipkin-contrib/zipkin-go-opentracing@4c9fbcb...f0f479a
apache/thrift@327ebb6...2b7365c
I audited every commit in the zipkin-go-opentracing diff and every
commit to the
lib/gopackage of the thrift diff.Release note (bug fix): Updated Zipkin library to avoid deadlock when
stopping Zipkin tracing.