cli/start: make SIGQUIT dump the stacks #36378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
cc @bdarnell |
|
Thanks for the PR! I commented on #35476 for general understanding for why we want this on top of the existing methods of introspecting the goroutines. Re: not exiting on SIGQUIT, this might be normal in Java but it's not normal in Go and also not normal according to wikipedia: https://en.wikipedia.org/wiki/Signal_(IPC)#SIGQUIT Overall my preference here is to solve the demand for this feature in a more ergonomical way, though I don't yet understand what the problem to be solved is. I'll wait until I learn about that before making any recommendations on what to do. |
knz
changed the title
|
RFAL |
What: in the title. Why: the Go standard behavior is to dump stacks upon SIGQUIT. This had been disabled since crdb v1.0 but is really useful to troubleshoot hanging servers. Release note (cli change): CockroachDB will now dump the stacks of all goroutines upon receiving SIGQUIT prior to terminating. This feature is intended for use while troubleshooting misbehaving nodes.
tbg
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45875.
What: in the title.
Why: the Go standard behavior is to dump stacks upon SIGQUIT.
This had been disabled since crdb v1.0 but is really useful
to troubleshoot hanging servers.
Release note (cli change): CockroachDB will now dump the stacks of all
goroutines upon receiving SIGQUIT prior to terminating. This feature
is intended for use while troubleshooting misbehaving nodes.