backport-19.1: debug zip improvements #36480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code used the sql connection to the first node to fetch all data. Unfortunately, we have to guess the SQL connection string for the other nodes (and may not get it right), but I've verified that this doesn't fail out the whole `debug zip` process. In the process of verifying that (running with one node down) I also fixed a few buglets related to that, including creating files multiple times and generally confused-looking output. Release note: None
This is achieved via a unit test. I went through all of the missing tables and made judgement calls on whether they needed to be included. This resulted in the inclusion of some obvious earlier omissions. I also went through the crdb_internal tables and added a naming convention and tried to add TODOs to all methods violating it. It's a bad idea to rename any of these; we should probably alias them to their desired name and leave the old name valid, somehow without listing it in `SHOW TABLES FROM crdb_internal`. Release note (bug fix): Data that was previously omitted from `debug zip` is now included.
|
This change is |
bdarnell
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
Please see individual PRs for details.
/cc @cockroachdb/release