cli: enforce inclusion of new crdb_internal tables in debug zip #36281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
LGTM |
This is achieved via a unit test. I went through all of the missing tables and made judgement calls on whether they needed to be included. This resulted in the inclusion of some obvious earlier omissions. I also went through the crdb_internal tables and added a naming convention and tried to add TODOs to all methods violating it. It's a bad idea to rename any of these; we should probably alias them to their desired name and leave the old name valid, somehow without listing it in `SHOW TABLES FROM crdb_internal`. Release note (bug fix): Data that was previously omitted from `debug zip` is now included.
tbg
force-pushed
the
fix/debug-zip-all-internal-tables
branch
from
b3f39cf
to
56d47ca
Compare
|
TFTR! bors r=andreimatei |
craig bot
pushed a commit
that referenced
this pull request
Mar 28, 2019
36281: cli: enforce inclusion of new crdb_internal tables in debug zip r=andreimatei a=tbg This is achieved via a unit test. I went through all of the missing tables and made judgement calls on whether they needed to be included. This resulted in the inclusion of some obvious earlier omissions. I also went through the crdb_internal tables and added a naming convention and tried to add TODOs to all tables violating it. It's a bad idea to rename any of these; we should probably alias them to their desired name and leave the old name valid, somehow without listing it in `SHOW TABLES FROM crdb_internal`. Release note (bug fix): Data that was previously omitted from `debug zip` is now included. Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is achieved via a unit test. I went through all of the missing
tables and made judgement calls on whether they needed to be included.
This resulted in the inclusion of some obvious earlier omissions.
I also went through the crdb_internal tables and added a naming
convention and tried to add TODOs to all tables violating it.
It's a bad idea to rename any of these; we should probably alias
them to their desired name and leave the old name valid, somehow
without listing it in
SHOW TABLES FROM crdb_internal.Release note (bug fix): Data that was previously omitted from
debug zipis now included.