release-19.1: storage/engine: fix handling of 0-length varstrings in RocksDBBatchReader #36965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader Previously, 0-length varstrings inadvertently cuased the reader to truncate the batch repr which would usually result in a call to `Next` complaining about the batch containing an unexpected number of entries. So far, it looks like the only effect of this would be "invalid batch" errors while using `cockroach debug` commands. It is possible there is a more serious effect, though. See cockroachdb#36937 Release note (bug fix): Fixed a bug in write batch decoding that could cause "invalid batch" errors while using `cockroach debug` commands to analyze data.
|
This change is |
|
LGTM |
|
TFTR! Merging on the assumption that @bdarnell will feel similarly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is urgent to merge for 19.1.0. On the other hand, it is an obvious bug with a simple fix and there could be a way to actually trigger it such that is has user visible effects.
Backport 1/1 commits from #36962.
/cc @cockroachdb/release
Previously, 0-length varstrings inadvertently cuased the reader to
truncate the batch repr which would usually result in a call to
Nextcomplaining about the batch containing an unexpected number of
entries. So far, it looks like the only effect of this would be "invalid
batch" errors while using
cockroach debugcommands. It is possiblethere is a more serious effect, though.
See #36937
Release note (bug fix): Fixed a bug in write batch decoding that could
cause "invalid batch" errors while using
cockroach debugcommands toanalyze data.