Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-19.1: storage/engine: fix handling of 0-length varstrings in RocksDBBatchReader #36965

Merged

Commits on Apr 19, 2019

  1. storage/engine: fix handling of 0-length varstrings in RocksDBBatchRe…

    …ader
    
    Previously, 0-length varstrings inadvertently cuased the reader to
    truncate the batch repr which would usually result in a call to `Next`
    complaining about the batch containing an unexpected number of
    entries. So far, it looks like the only effect of this would be "invalid
    batch" errors while using `cockroach debug` commands. It is possible
    there is a more serious effect, though.
    
    See cockroachdb#36937
    
    Release note (bug fix): Fixed a bug in write batch decoding that could
    cause "invalid batch" errors while using `cockroach debug` commands to
    analyze data.
    petermattis committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    94e6c86 View commit details
    Browse the repository at this point in the history