-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
demo: Add location information to default demo localities. #40229
Conversation
Sweet! I think we could take this one step further and have |
👍 on pre-populating however I could also see wisdom in providing a SQL data file as a separate DLC, with two tiers: one free tier with just 3 locations that's included in the binary (and used for @piyush-singh maybe food for thought |
In the name of reducing friction for developers, and inspiring developer love, I would like to push back against that idea - the data is all free and easily accessible. Let's add it by default and be done with it - I don't want our users to see a semi-working node map and have to figure out how to make it fully-working. |
ok an unrelated question - are you OK with these region names? ISTM these are identifiers that are specific to GCP, is the mapping between identifier and geographical location the same for EC2 and Azure? |
The mappings are different. Conveniently, all 3 clouds provide different region names :) |
I understand the idea of wanting to help marketing out here but I agree with @jordanlewis that the above proposal creates unnecessary developer friction. |
oh that's handy 🎉 sure then, it will make tutorials even more spiffy |
oh, you want these to be published when starting any cluster, not just the demo? If we are doing that, might as well just prepopulate the system locations table with information about every region for all the cloud providers -- its on our docs anyway (https://www.cockroachlabs.com/docs/v19.1/enable-node-map.html) |
Yeah, that's what I was talking about too. I think we should just go ahead and do that - would help a lot of people. |
Yeah i agree--would be great |
I set up populating the system.locations table as a migration right now, but I'm still looking into how to bake in that information during cluster startup. As of now I have the migration be a noop if the system.locations table is not empty (to avoid overwriting users data), but we could change that. PTAL |
Fixes cockroachdb#39937. Adds default latitude and longitude information for the default localities in cockroach demo so that the web UI is pre-populated. Release note (cli change): Add location information to default localities to populate web UI for cockroach demo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice.
bors r=knz I can put up a PR later with all the GCE localities and locations set up, rather than just the ones used in the demo cluster. |
40229: demo: Add location information to default demo localities. r=knz a=rohany Fixes #39937. Adds default latitude and longitude information for the default localities in cockroach demo so that the web UI is pre-populated. Release note (cli change): Add location information to default localities to populate web UI for cockroach demo. 40271: demo: Add a Movr workload to run in cockroach demo r=danhhz,nstewart a=rohany Fixes #39944. When the `--with-load` flag is passed to demo, a sample movr workload is run against the database. I tried my best to replicate the Movr load in Nate's example script. Based on talks with Dan, it was better to copy out a simpler version of the logic to run the workload than try to hook into workload. Release note (cli change): Add a workload to run with cockroach demo. 40320: randutil: allow COCKROACH_RANDOM_SEED to seed NewPseudoRand r=mjibson a=mjibson Multiple people have been confused about the lack of interaction between NewPseudoRand (which used to always generate a random seed) and COCKROACH_RANDOM_SEED (which only influenced using the global rand methods). Release note: None Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu> Co-authored-by: Matt Jibson <matt.jibson@gmail.com>
Build succeeded |
Fixes #39937.
Adds default latitude and longitude information for the default
localities in cockroach demo so that the web UI is pre-populated.
Release note (cli change): Add location information to default
localities to populate web UI for cockroach demo.