parser: handle FOR UPDATE [ OF tables ] #40962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds no-op parsing to this extension of the for locked clause, which allows specifying a subset of the tables in the FROM list to lock. We don't handle FOR UPDATE at all, so this syntax is also no-op. This commit also adds explicit "not supported" errors for the SKIP LOCKED and NOWAIT variants, which we can't properly support at this time. Release note (sql change): add parsing for FOR UPDATE [ OF tables ] form. Release justification: low risk compatibility change; no functionality changed.
|
This change is |
Release note: None Release justification: low-risk telemetry improvement.
jordanlewis
force-pushed
the
for-update-of
branch
from
8262218
to
64415f6
Compare
rafiss
approved these changes
Sep 23, 2019
There was a problem hiding this comment.
awesome! this is helpful to look at since i was interested in using the "unimplemented with issue" but didn't know how it was done
Reviewed 7 of 8 files at r1, 2 of 2 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @RaduBerinde)
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 23, 2019
40962: parser: handle FOR UPDATE [ OF tables ] r=jordanlewis a=jordanlewis This commit adds no-op parsing to this extension of the for locked clause, which allows specifying a subset of the tables in the FROM list to lock. We don't handle FOR UPDATE at all, so this syntax is also no-op. This commit also adds explicit "not supported" errors for the SKIP LOCKED and NOWAIT variants, which we can't properly support at this time. Also, add an explicit error for DELETE FROM ... USING … Release note (sql change): add parsing for FOR UPDATE [ OF tables ] form, and explicit error for DELETE FROM ... USING ... Release justification: low risk compatibility change; no functionality changed. Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds no-op parsing to this extension of the for locked
clause, which allows specifying a subset of the tables in the FROM list
to lock. We don't handle FOR UPDATE at all, so this syntax is also
no-op.
This commit also adds explicit "not supported" errors for the SKIP
LOCKED and NOWAIT variants, which we can't properly support at this
time.
Also, add an explicit error for DELETE FROM ... USING …
Release note (sql change): add parsing for FOR UPDATE [ OF tables ]
form, and explicit error for DELETE FROM ... USING ...
Release justification: low risk compatibility change; no functionality
changed.