builtins: fix extract from timestamptz to be ctx time zone aware #42632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
When using extract on timestamptz, we should be aware of what time zone we are currently in when performing the operations. This PR further adds 'timezone', 'timezone_hour' and 'timezone_minute' to the extract command for timestamptz. Release note (sql change): Previously, when using `extract` on a timestamptz it would always perform the operation as if it was in UTC. In this PR, it will change it to match the environment's location in which `extract` was executed in. Furthermore, `timezone`, `timezone_hour` and `timezone_minute` are added to the `extract` command.
otan
force-pushed
the
otan-extract_more
branch
from
6467bfc
to
069e261
Compare
solongordon
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis and @rafiss)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 21, 2019
42632: builtins: fix extract from timestamptz to be ctx time zone aware r=otan a=otan Resolves cockroachdb/django-cockroachdb#47 When using extract on timestamptz, we should be aware of what time zone we are currently in when performing the operations. This PR further adds 'timezone', 'timezone_hour' and 'timezone_minute' to the extract command for timestamptz. Release note (sql change): Previously, when using `extract` on a timestamptz it would always perform the operation as if it was in UTC. In this PR, it will change it to match the environment's location in which `extract` was executed in. Furthermore, `timezone`, `timezone_hour` and `timezone_minute` are added to the `extract` command. Co-authored-by: Oliver Tan <otan@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves cockroachdb/django-cockroachdb#47
When using extract on timestamptz, we should be aware of what time zone
we are currently in when performing the operations.
This PR further adds 'timezone', 'timezone_hour' and 'timezone_minute'
to the extract command for timestamptz.
Release note (sql change): Previously, when using
extracton atimestamptz it would always perform the operation as if it was in UTC.
In this PR, it will change it to match the environment's location in
which
extractwas executed in. Furthermore,timezone,timezone_hourandtimezone_minuteare added to theextractcommand.