Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-19.1: changefeed schema change nemeses and fixes #43037

Merged
merged 3 commits into from
Dec 17, 2019

Commits on Dec 10, 2019

  1. changefeedccl: add schema change events to nemeses

    Currently, the changefeed nemeses system does not support schema
    changes. This has previously allowed some fairly critical bugs to creep
    past our testing.
    
    This PR adds support for schema change events to the changefeed nemeses.
    
    Release note: None.
    aayushshah15 authored and danhhz committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    316a514 View commit details
    Browse the repository at this point in the history
  2. changefeedccl: add scan boundaries based on change in set of columns

    Currently, the changefeed poller detects a scan boundary when it
    detects that the last version of a table descriptor has a pending
    mutation but the current version doesn't. In case of an `ALTER TABLE
    DROP COLUMN` statement, the point at which this happens is the point at
    which the schema change backfill completes. However, this is incorrect
    since the dropped column gets logically dropped before that.
    
    This PR corrects this problem by instead using the set of column
    descriptors within the current and previous table descriptors to detect a
    scan boundary.
    
    Fixes cockroachdb#41961
    
    Release note (bug fix): Changefeeds now emit backfill row updates for
                            dropped column when the table descriptor drops
                            that column.
    aayushshah15 authored and danhhz committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    d976707 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2019

  1. changefeedccl: adjust backport for release-19.1

    The cloud storage sink uses the original filename format, so unlike
    release-19.2, we also need to pad schemaID.
    
    Release note: None
    danhhz committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    da56d30 View commit details
    Browse the repository at this point in the history