Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: sql: fix panic when searching for equivalent renders #43118

Merged
merged 1 commit into from Dec 12, 2019

Conversation

@yuzefovich
Copy link
Contributor

yuzefovich commented Dec 11, 2019

Backport 1/1 commits from #35995.

/cc @cockroachdb/release

Fixes: #42836.


Previously, certain kinds of window functions could generate a panic
when trying to reuse equivalent renders when those renders were tuples.
This is fixed by comparing the types using the Equivalent method instead
of ==.

Release note (bug fix): fix panics caused by certain window functions
that operate on tuples

Previously, certain kinds of window functions could generate a panic
when trying to reuse equivalent renders when those renders were tuples.
This is fixed by comparing the types using the Equivalent method instead
of ==.

Release note (bug fix): fix panics caused by certain window functions
that operate on tuples
@yuzefovich yuzefovich requested a review from jordanlewis Dec 11, 2019
@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Dec 11, 2019

This change is Reviewable

Copy link
Member

jordanlewis left a comment

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)

@yuzefovich yuzefovich merged commit 0e084cb into cockroachdb:release-2.1 Dec 12, 2019
2 checks passed
2 checks passed
GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details
@yuzefovich yuzefovich deleted the yuzefovich:backport2.1-35995 branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.