release-2.1: sql: fix panic when searching for equivalent renders #43118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, certain kinds of window functions could generate a panic when trying to reuse equivalent renders when those renders were tuples. This is fixed by comparing the types using the Equivalent method instead of ==. Release note (bug fix): fix panics caused by certain window functions that operate on tuples
|
This change is |
jordanlewis
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #35995.
/cc @cockroachdb/release
Fixes: #42836.
Previously, certain kinds of window functions could generate a panic
when trying to reuse equivalent renders when those renders were tuples.
This is fixed by comparing the types using the Equivalent method instead
of ==.
Release note (bug fix): fix panics caused by certain window functions
that operate on tuples