release-19.2: sql: fix locality information in show ranges #44312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the locality information in show ranges was incorrectly assuming that range descriptors are node id based. This was causing a mismatch between replicas tuple and the locality. To address this, this change makes the locality info be based on store ids. Fixes cockroachdb#43755, cockroachdb#30940 Release note (sql change): Show ranges now shows locality information consistent with the range descriptor when node id and store id don't match..
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #43807.
/cc @cockroachdb/release
Previously the locality information in show ranges was incorrectly assuming
that range descriptors are node id based.
This was causing a mismatch between replicas tuple and the locality.
To address this, this change makes the locality info be based on store ids.
Fixes #43755, #30940
Release note (sql change): Show ranges now shows locality information
consistent with the range descriptor when node id and store id don't match..