Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-19.2: sql: allow booleans in SET tracing and friendlier error message #44347

Merged
merged 1 commit into from
Jan 24, 2020

Commits on Jan 24, 2020

  1. sql: allow booleans in SET tracing and friendlier error message

    Previously, we would fail an assertion if a datum of the wrong type is
    provided in `SET tracing` query (only strings were allowed). This resulted
    in an internal error and printing out of the stack trace which can be
    scary to users. This commit removes the assertion and makes it a regular
    query error.
    
    Also, booleans are now allowed as argument to `SET tracing`, and `true`
    is mapped to `on` mode and `false` to `off`.
    
    Release note (sql change, bug fix): Previously, CockroachDB would return
    an internal error when using `SET tracing` with any type other than
    string. Now it will return a regular query error. Additionally, boolean
    arguments are now supported in `SET tracing`, and `true` is mapped to
    `on` mode of tracing whereas `false` is mapped to `off`.
    yuzefovich committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    4c50029 View commit details
    Browse the repository at this point in the history