colexec: fix cfetcher with interleaved tables with NULL in key #47035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I don't like that we have to iterate over all the columns here when we skip a k/v due to it being interleaved. I think instead when we actually decode the k/v into values we should reset the null before decoding the key, so that previous null writes don't shadow the decoded value. |
yuzefovich
force-pushed
the
fix-interleaved-null
branch
from
37583e9
to
0104810
Compare
|
Good point, updated. |
|
❌ The GitHub CI (Cockroach) build has failed on 01048105. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. I am experimental - my owner is otan. |
rohany
approved these changes
Apr 6, 2020
Previously `cFetcher` could decode an interleaved table's `NULL` value which would set the NULL in the corresponding column vector but would not unset the null while it should have. Release note (bug fix): Previously, CockroachDB could incorrectly consider non-NULL value from an interleaved parent table to be NULL when the interleaved child has NULL value in the row with the corresponding index key, and now this has been fixed.
yuzefovich
force-pushed
the
fix-interleaved-null
branch
from
0104810
to
732f92d
Compare
|
TFTR! bors r+ |
|
❌ The GitHub CI (Cockroach) build has failed on 732f92d8. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. I am experimental - my owner is otan. |
|
bors r+ |
Build succeeded |
This was referenced Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
cFetchercould decode an interleaved table'sNULLvaluewhich would set the NULL in the corresponding column vector but would
not unset the null while it should have.
Fixes: #47029.
Release note (bug fix): Previously, CockroachDB could incorrectly
consider non-NULL value from an interleaved parent table to be NULL when
the interleaved child has NULL value in the row with the corresponding
index key, and now this has been fixed.