release-20.1: sql: prevent time-related precision during upgrade from 19.2 -> 20.1 #47438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention is to backport this if we think this change is important. Release note (sql change): We previously allowed mixed type 20.1/19.2 upgrades to add time precision. However, the 19.2 would disrespect the precision component and we documented that. To make this cleaner, we instead only allow precision to be specified in time-related types when the version upgrade is complete.
|
Welcome back, creator. Thank you for testing me. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
This change is |
rohany
approved these changes
Apr 13, 2020
|
Should we check off one of the boxes in release blockers issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #47425.
/cc @cockroachdb/release
The intention is to backport this if we think this change is important.
Release note (sql change): We previously allowed mixed type 20.1/19.2
upgrades to add time precision. However, the 19.2 would disrespect the
precision component and we documented that. To make this cleaner, we
instead only allow precision to be specified in time-related types when
the version upgrade is complete.