sql: add square and cube root unary operators (|/ and ||/) #47680
Conversation
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
This change is |
There was a problem hiding this comment.
CC @yuzefovich if you want to take a quick look as well
Reviewable status:
complete! 1 of 0 LGTMs obtained
There was a problem hiding this comment.
Very nice work! 
Reviewed 13 of 13 files at r1.
Reviewable status:
pkg/sql/logictest/testdata/logic_test/operator, line 7 at r1 (raw file):
query error cannot take square root of a negative number SELECT |/ -1.0::float
I'd be curious to see test cases with NULLs and NaNs (not sure if those are applicable here though).
nit: I think this test belongs in sem/tree/eval folder.
hueypark
force-pushed
the
operator-sqrt-cbrt
branch
from
2fcc5ea
to
15c5394
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/sql/logictest/testdata/logic_test/operator, line 7 at r1 (raw file):
Previously, yuzefovich wrote…
I'd be curious to see test cases with
NULLs andNaNs (not sure if those are applicable here though).nit: I think this test belongs in
sem/tree/evalfolder.
Done.
There was a problem hiding this comment.
Thanks for your contribution!
bors r=raduberinde,yuzefovich
Reviewed 2 of 2 files at r2.
Reviewable status:
Build failed (retrying...) |
Build failed (retrying...) |
Build failed (retrying...) |
Build failed |
|
Hey @hueypark, do you mind rebasing your PR on top of the current master? We have a fix for some infrastructure problems in there that we need to pick up before merging this. |
Fixes cockroachdb#47544 Release note (sql change): add square and cube root unary operators (|/ and ||/)
hueypark
force-pushed
the
operator-sqrt-cbrt
branch
from
15c5394
to
96193f1
Compare
|
@yuzefovich Done! |
|
❌ The GitHub CI (Cockroach) build has failed on 96193f1a. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
Thanks! The build failure seems like a flake to me. bors r=raduberinde,yuzefovich |
Build succeeded |
Fixes #47544
Release note (sql change): add square and cube root unary operators (|/ and ||/)