Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: disable block profiling by default #48133

Merged
merged 1 commit into from Apr 29, 2020

Commits on Apr 29, 2020

  1. cli: disable block profiling by default

    Disable block profiles by default as they consume a small but measurable
    amount of CPU: 1.5% of CPU in one tpcc experiment. Additionally, block
    profiling affects Pebble more than RocksDB as RocksDB's synchronization
    primitives are invisible to the Go runtime. This levels the playing
    field.
    
    Release note (performance improvement): Disable the Go runtime block
    profile by default which results in a small but measurable reduction in
    CPU usage. The block profile has diminished in utility with the advent
    of mutex contention profiles and is almost never used during performance
    investigations.
    petermattis committed Apr 29, 2020
    Copy the full SHA
    8c5c35c View commit details
    Browse the repository at this point in the history