opt: fix string with spaces in SHOW STATISTICS USING JSON #48514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `SHOW STATISTICS USING JSON` result strings with spaces have extra single quotes, which become part of the actual string when injecting the stats. This change fixes this and adds a "roundtripping" test. Fixes cockroachdb#48500. Release note (bug fix): SHOW STATISTICS USING JSON contains incorrect single quotes for strings with spaces inside histograms.
|
This change is |
rytaft
approved these changes
May 7, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r+ |
Build failed |
This was referenced May 7, 2020
|
"no space left on device" bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
SHOW STATISTICS USING JSONresult strings with spaces have extra singlequotes, which become part of the actual string when injecting the stats.
This change fixes this and adds a "roundtripping" test.
Fixes #48500.
Release note (bug fix): SHOW STATISTICS USING JSON contains incorrect single
quotes for strings with spaces inside histograms.