sql,importccl: prevent DROP DATABASE CASCADE if there are offline tables #48596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
changed the title
dt
approved these changes
May 8, 2020
|
❌ The GitHub CI (Cockroach) build has failed on ecafe0ec. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
… tables See the issue for more commentary on the problem. In short, we never dropped offline tables during `DROP DATABASE ... CASCADE` which would end up leaving those tables completely orphaned. Orphaned tables with no parent are a problem. Perhaps it would be better to stop the relevant jobs and then clean up after them but that's a much more involved fix. Fixes cockroachdb#48589. Release note (bug fix): Prevent dropping of databases which contain tables which are currently offline due to `IMPORT` or `RESTORE`. Previously dropping a database in this state could lead to a corrupted schema which prevented running backups.
ajwerner
force-pushed
the
ajwerner/fix-drop-cascade-with-offline-tables
branch
from
ecafe0e
to
a52d50d
Compare
|
TFTR! bors r=dt |
Build succeeded |
This was referenced May 8, 2020
Merged
|
Nice - thanks for using a proper pgcode as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the issue for more commentary on the problem. In short, we never dropped
offline tables during
DROP DATABASE ... CASCADEwhich would end up leavingthose tables completely orphaned. Orphaned tables with no parent are a problem.
Perhaps it would be better to stop the relevant jobs and then clean up after
them but that's a much more involved fix.
Fixes #48589.
Release note (bug fix): Prevent dropping of databases which contain tables
which are currently offline due to
IMPORTorRESTORE. Previously droppinga database in this state could lead to a corrupted schema which prevented
running backups.