release-19.2: sql,importccl: prevent DROP DATABASE CASCADE if there are offline tables #48612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #48596.
/cc @cockroachdb/release
See the issue for more commentary on the problem. In short, we never dropped
offline tables during
DROP DATABASE ... CASCADE
which would end up leavingthose tables completely orphaned. Orphaned tables with no parent are a problem.
Perhaps it would be better to stop the relevant jobs and then clean up after
them but that's a much more involved fix.
Fixes #48589.
Release note (bug fix): Prevent dropping of databases which contain tables
which are currently offline due to
IMPORT
orRESTORE
. Previously droppinga database in this state could lead to a corrupted schema which prevented
running backups.