release-20.1: backupccl: create pending schema changes job upon restore #48850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates restore to start schema change jobs for any pending mutations that are left on the table descriptor. These mutations may be found on the table descriptor if they were backed up while in the middle of a schema change. Release note (bug fix): Properly support restoring tables that were backed up while they were in the middle of a schema change.
|
This change is |
thoszhang
approved these changes
May 14, 2020
There was a problem hiding this comment.
Reviewed 43 of 43 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #47588.
/cc @cockroachdb/release
This commit updates restore to start schema change jobs for any pending
mutations that are left on the table descriptor. These mutations may be
found on the table descriptor if they were backed up while in the middle
of a schema change.
Fixes #44019.
Release note (bug fix): Properly support restoring tables that were
backed up while they were in the middle of a schema change.