kvserver: relax resolved ts push interval under testrace #50294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
approved these changes
Jun 17, 2020
nvanbenschoten
approved these changes
Jun 17, 2020
Fixed cockroachdb#50091 Some rangefeed tests had a really bad time under stressrace on TC machines (presumably overloaded machines because of the tests of 4 packages running concurrently). These tests were setting very low thresholds for the resolved timestamp transaction pusher, and so transactions in these tests were constantly retrying because the resolved timestamp sweeper kept pushing them and, by the time they refreshed, they got pushed again. This patch bumps the thresholds when running under race. On a GPC n1-standard-8 machine, running TestClosedTimestampCanServeWhConflictingIntent under stressrace with concurrency 8 made the test never complete. Now it completes reliably. Release note: None
andreimatei
force-pushed
the
small.testrace-resolvedts
branch
from
ca2bb69
to
b79462a
Compare
andreimatei
commented
Jun 18, 2020
There was a problem hiding this comment.
done
I've also noticed that a bunch of tests calling setupTestClusterForClosedTimestampTesting() were skipped under race even before your extra skipping the other day. I intend to see if the can now be unskipped, but separately.
Reviewable status:
complete! 0 of 0 LGTMs obtained
andreimatei
commented
Jun 18, 2020
Build succeeded |
andreimatei
added a commit
to andreimatei/cockroach
that referenced
this pull request
Jun 18, 2020
A bunch of related tests using setupTestClusterForClosedTimestampTesting() were skipped under testrace because the transaction limits set for these TestClusters don't go well with testrace and loaded machines. This was done inconsistently (not all such tests were skipped). The relevant limits have been tweaked in cockroachdb#50294, so these tests should be good now. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #50091
Some rangefeed tests had a really bad time under stressrace on TC
machines (presumably overloaded machines because of the tests of 4
packages running concurrently). These tests were setting very low
thresholds for the resolved timestamp transaction pusher, and so
transactions in these tests were constantly retrying because the
resolved timestamp sweeper kept pushing them and, by the time they
refreshed, they got pushed again. This patch bumps the thresholds when
running under race.
On a GPC n1-standard-8 machine, running
TestClosedTimestampCanServeWhConflictingIntent under stressrace with
concurrency 8 made the test never complete. Now it completes reliably.
Release note: None