Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: unskip a bunch of closedts tests under testrace #50391

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

kvserver: unskip a bunch of closedts tests under testrace #50391

wants to merge 1 commit into from

Conversation

andreimatei
Copy link
Contributor

A bunch of related tests using
setupTestClusterForClosedTimestampTesting() were skipped under testrace
because the transaction limits set for these TestClusters don't go well
with testrace and loaded machines. This was done inconsistently (not all
such tests were skipped). The relevant limits have been tweaked
in #50294, so these tests should be good now.

Release note: None

@andreimatei
kvserver: unskip a bunch of closedts tests under testrace
009eec0 
A bunch of related tests using
setupTestClusterForClosedTimestampTesting() were skipped under testrace
because the transaction limits set for these TestClusters don't go well
with testrace and loaded machines. This was done inconsistently (not all
such tests were skipped). The relevant limits have been tweaked
in cockroachdb#50294, so these tests should be good now.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

aayushshah15
aayushshah15 approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@aayushshah15 aayushshah15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @tbg)

@aayushshah15
Copy link
Contributor

:lgtm:

@tbg
Copy link
Member

tbg commented Jun 19, 2020

I'll take a look when it's green:

--- FAIL: TestClosedTimestampCanServeAfterSplitAndMerges (79.55s)
    closed_timestamp_test.go:294: 
        	Error Trace:	closed_timestamp_test.go:294
        	Error:      	Expected nil, but got: &roachpb.NotLeaseHolderError{Replica:roachpb.ReplicaDescriptor{NodeID:3, StoreID:3, ReplicaID:2, Type:(*roachpb.ReplicaType)(nil)}, LeaseHolder:(*roachpb.ReplicaDescriptor)(0xc0010f8e28), Lease:(*roachpb.Lease)(0xc0010f8e10), RangeID:45, CustomMsg:""}
        	Test:       	TestClosedTimestampCanServeAfterSplitAndMerges

@tbg tbg removed their request for review June 25, 2020 09:29
@tbg tbg added the X-noremind Bots won't notify about PRs with X-noremind label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aayushshah15 aayushshah15 aayushshah15 approved these changes

Assignees
No one assigned
Labels
X-noremind Bots won't notify about PRs with X-noremind
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andreimatei @cockroach-teamcity @aayushshah15 @tbg