release-19.2: sql: only set DropJobID on old table descriptor in TRUNCATE #50714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, we'd populate the DropJobID in both the new and old tables when truncating a table. This causes problems later. Note that this commit does not add robustness to clusters which have table descriptors with a DropJobID due to this bug. That will come in a follow-up. Touches cockroachdb#50587. Release note (bug fix): Fixed a bug in TRUNCATE which could later leave tables in a state where they cannot be renamed.
|
This change is |
|
I'll be issuing a separate PR to add robustness to this situation as that PR should merge to master and get backported to 20.1, 19.2, and 19.1. |
spaskob
reviewed
Jun 27, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @lucy-zhang and @spaskob)
thoszhang
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
Jun 29, 2020
In cockroachdb#50587 we discovered that TRUNCATE would leave a DropJobID on both the new and old tables. This situation was rectified in cockroachdb#50714. In most cases that job ID is ignored. However, in release-19.2 and earlier, it would prevent RENAME operations from completing. To deal with this, we repair the descriptor by removing the DropJobID. We also, for additional protection, prevent the failure to update the job from preventing progress. Release note (bug fix): Fixed a bug which could prevent previously TRUNCATED tables from being renamed.
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
Jun 29, 2020
In cockroachdb#50587 we discovered that TRUNCATE would leave a DropJobID on both the new and old tables. This situation was rectified in cockroachdb#50714. In most cases that job ID is ignored. However, in release-19.2 and earlier, it would prevent RENAME operations from completing. To deal with this, we repair the descriptor by removing the DropJobID. We also, for additional protection, prevent the failure to update the job from preventing progress. Release note (bug fix): Fixed a bug which could prevent previously TRUNCATED tables from being renamed.
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
Jun 29, 2020
In cockroachdb#50587 we discovered that TRUNCATE would leave a DropJobID on both the new and old tables. This situation was rectified in cockroachdb#50714. In most cases that job ID is ignored. However, in release-19.2 and earlier, it would prevent RENAME operations from completing. To deal with this, we repair the descriptor by removing the DropJobID. We also, for additional protection, prevent the failure to update the job from preventing progress. Release note (bug fix): Fixed a bug which could prevent previously TRUNCATED tables from being renamed.
ajwerner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we'd populate the DropJobID in both the new and old
tables when truncating a table. This causes problems later. Note that this
commit does not add robustness to clusters which have table descriptors with
a DropJobID due to this bug. That will come in a follow-up.
Touches #50587.
Release note (bug fix): Fixed a bug in TRUNCATE which could later leave
tables in a state where they cannot be renamed.