release-19.2: sql: fix incorrect interleaved join planning with limits #51435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interleaved joiner doesn't handle hard limits and the planning code doesn't check for this. This change fixes the planning and adds an assertion in the interleaved joiner. Fixes cockroachdb#51397. Release note (bug fix): fixed incorrect results in some cases involving joins on interleaved tables with limits.
|
This change is |
yuzefovich
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #51398.
/cc @cockroachdb/release
The interleaved joiner doesn't handle hard limits and the planning
code doesn't check for this. This change fixes the planning and adds
an assertion in the interleaved joiner.
Fixes #51397.
Release note (bug fix): fixed incorrect results in some cases
involving joins on interleaved tables with limits.