sql: switch table and index in EXPLAIN (DISTSQL) diagrams #52085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
This commit switches from `index@table` to `table@index` to be in line with how index hints are given. Release note (sql change): `EXPLAIN (DISTSQL)` diagrams have been updated by switching table name with index name (previously, we had syntax `index@table`, and now we have `table@index`).
|
Build failed (retrying...): |
|
Build succeeded: |
This was referenced Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches from
index@tabletotable@indexto be in linewith how index hints are given.
Release note (sql change):
EXPLAIN (DISTSQL)diagrams have beenupdated by switching table name with index name (previously, we had
syntax
index@table, and now we havetable@index).