Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: observe lease transfer interval in considerRebalance #54322

Commits on Sep 14, 2020

  1. kvserver: observe lease transfer interval in considerRebalance

    This commit plumbs the lease transfer rate limit into the lease transfer which
    occurs as a part of rebalancing decision making. The decision about whether a
    node should remove itself for the purpose of rebalancing happens at a much
    higher rate than the the actual rebalancing. This can lead to massive
    oscillations of leaseholders as the calculation on which replica should be
    removed in the face of node addition changes dramatically. We utilize
    a rate limit in lease transfer decisions to smooth this decision making
    elsewhere. This limit however is not utilized currently when deciding to
    transfer a lease for the purpose of rebalancing data. This change has
    shown very positive impact mitigating these lease transfer storms. See
    the commentary on cockroachdb#51867.
    
    Release note (bug fix): Made lease transfers during rebalancing adhere
    to the rate limit utilized in other lease transfer cases which eliminates
    unexpected lease oscillations when adding a new node.
    ajwerner committed Sep 14, 2020
    Copy the full SHA
    c719214 View commit details
    Browse the repository at this point in the history