Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-20.2: backport spatial builtin fixes #54564

Merged

Conversation

otan
Copy link
Contributor

@otan otan commented Sep 18, 2020

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

adzimzf and others added 3 commits September 17, 2020 19:08
Currently PostGIS has the ST_SwapOrdinates, but CRDB hasn't.

Fixes cockroachdb#49050.

Release note (sql change): Implemented the geometry based builtins
`ST_SwapOrdinates`.
ST_Intersection returns the empty element of one side instead of
whatever GEOS returns if any side is empty.

Release note: None
Release note (sql change): Implement the geometry builtin
`ST_OrderingEquals`.
@otan otan requested review from sumeerbhola and a team September 18, 2020 15:03
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan changed the title release-20.2: backport geospatial builtin fixes release-20.2: backport spatial builtin fixes Sep 18, 2020
Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, 3 of 3 files at r2.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @sumeerbhola)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants