release-20.1: backupccl: properly propagate error when failing to commit job txn #54968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
adityamaru
approved these changes
Sep 29, 2020
miretskiy
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @miretskiy)
This bug was introduced in 20.1. It means that any errors to commit the job are not reported and instead an inscrutible error is reported. ``` ERROR: cannot resume *backupccl.backupResumer job which is not committed ``` Fixes cockroachdb#54572. Release note (bug fix): Fixed a bug which lead to inscrutible errors being returned when creating a backup failed, for example, due to protected timestamp limits.
Before this error was swallowed. It's not known that an error is ever really returned here and there's no sentry report indicating that there has been one so omitting a release note. Release note: None
ajwerner
force-pushed
the
backport20.1-54577
branch
from
2cd5d04
to
ad0570a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #54577.
/cc @cockroachdb/release
This bug was introduced in 20.1. It means that any errors to commit the job
are not reported and instead an inscrutible error is reported.
Release note (bug fix): Fixed a bug which lead to inscrutible errors being
returned when creating a backup failed, for example, due to protected timestamp
limits.