Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-20.1: backupccl: properly propagate error when failing to commit job txn #54968

Merged
merged 2 commits into from
Oct 9, 2020
Merged

release-20.1: backupccl: properly propagate error when failing to commit job txn #54968

merged 2 commits into from
Oct 9, 2020

Commits on Oct 9, 2020

  1. backupccl: properly propagate error when failing to commit job txn 

    This bug was introduced in 20.1. It means that any errors to commit the job
are not reported and instead an inscrutible error is reported.

```
 ERROR: cannot resume *backupccl.backupResumer job which is not committed
```

Fixes cockroachdb#54572.

Release note (bug fix): Fixed a bug which lead to inscrutible errors being
returned when creating a backup failed, for example, due to protected timestamp
limits.
    @ajwerner
    ajwerner committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    e31ccd8 View commit details
    Browse the repository at this point in the history

  2. backupccl: return errors from the transaction which creates restore jobs 

    Before this error was swallowed. It's not known that an error is ever really
returned here and there's no sentry report indicating that there has been
one so omitting a release note.

Release note: None
    @ajwerner
    ajwerner committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    ad0570a View commit details
    Browse the repository at this point in the history