release-20.2: sql: disallow txn stats collection if stat collection threshold is set #56380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a transaction was comprised of statements that overshot the configured `sql.metrics.statement_details.threshold`, we would record the statementID for the txn even though there was no record of the statementID in the statement stats. This could prove confusing. This patch blanket disallows txn stats collection if the cluster setting is configured. Closes cockroachdb#54697 Release note (admin ui change): Transaction statistics are no longer recorded if the `sql.metrics.statement_details.threshold` cluster setting has been enabled.
|
This change is |
solongordon
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #55224.
/cc @cockroachdb/release
Previously, when a transaction was comprised of statements that
overshot the configured
sql.metrics.statement_details.threshold, wewould record the statementID for the txn even though there was no
record of the statementID in the statement stats. This could prove
confusing. This patch blanket disallows txn stats collection if the
cluster setting is configured.
Closes #54697
Release note (admin ui change): Transaction statistics are no longer
recorded if the
sql.metrics.statement_details.thresholdclustersetting has been enabled.