release-20.1: sql: handle bool values for compat-only session vars #56814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
approved these changes
Nov 17, 2020
otan
reviewed
Nov 17, 2020
| @@ -340,4 +340,13 @@ SET enable_zigzag_join = 'false'; | |||
| SET enable_zigzag_join = on; | |||
| SET enable_zigzag_join = off; | |||
| SET enable_zigzag_join = true; | |||
| SET enable_zigzag_join = false | |||
| SET enable_zigzag_join = false; | |||
Release note (bug fix): Some boolean session variables would only accept
string ("true" or "false") values. Now they accept unquoted true or
false values too.
rafiss
force-pushed
the
backport20.1-56662
branch
from
064c33b
to
f2e3dae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #56662.
/cc @cockroachdb/release
Release note (bug fix): Some boolean session variables would only accept
string ("true" or "false") values. Now they accept unquoted true or
false values too.