sql: categorize undefined column error when adding unique constraints #57316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
Previously, adding a unique constraint to a table on one or more columns that do not exist would cause uncategorized error. Now, the error is categorized as pgcode.UndefinedColumn. Release note (sql change): A pgcode.UndefinedColumn will now be returned when adding a unique constraint to one or more undefined columns.
jayshrivastava
force-pushed
the
categorize-undef-column-add-unique-constraint
branch
from
76da28a
to
b2d0d19
Compare
|
bors r=ajwerner |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, adding a unique constraint to a table on one or more columns
that do not exist would cause uncategorized error. Now, the error is
categorized as pgcode.UndefinedColumn.
Closes: #57314
Release note (sql change): A pgcode.UndefinedColumn will now be returned
when adding a unique constraint to one or more undefined columns.